Expose minDistance scalar UDFs#135
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
Member
Author
Reviewer's quickstart — ~2-3 minutesWhat this PR does: Expose minDistance scalar UDFs. Risk: focused, single-purpose. Spot-check the source diff + matching tests; CI confirms. Cross-link: Linux arm64 CI here needs #161 for the orthogonal |
estebanzimanyi
force-pushed
the
fix/bump-meos-pin
branch
from
b591405 to
4beb327
Compare
estebanzimanyi
force-pushed
the
feat/mindistance-udf-udaf-scaffold
branch
from
2cc3079 to
a815913
Compare
estebanzimanyi
changed the base branch from
fix/bump-meos-pin
to
fix/bump-meos-pin-wasm-pgconfig
estebanzimanyi
changed the base branch from
fix/bump-meos-pin-wasm-pgconfig
to
fix/bump-meos-pin
estebanzimanyi
force-pushed
the
fix/bump-meos-pin
branch
4 times, most recently
from
fa2de57 to
17588c0
Compare
estebanzimanyi
force-pushed
the
feat/mindistance-udf-udaf-scaffold
branch
from
a815913 to
ca20a89
Compare
estebanzimanyi
force-pushed
the
fix/bump-meos-pin
branch
from
40bf218 to
45df2ad
Compare
estebanzimanyi
force-pushed
the
feat/mindistance-udf-udaf-scaffold
branch
from
ca20a89 to
3051e8f
Compare
Registers minDistance(tgeompoint, geometry), minDistance(geometry, tgeompoint), and minDistance(tgeompoint, tgeompoint) following the nearestApproachDistance pattern. The geo-typed forms reuse the NAD kernel since NAD reduces to spatial-min when one argument has no time dimension; the tgeompoint/tgeompoint form calls the threshold-aware mindistance_tgeo_tgeo kernel. The canonical cross-join shape is MIN(minDistance(t1, t2)) with GROUP BY, the cloud-SQL-natural Solution-2 form; MobilityDB exposes the same signature as a 2-ary aggregate and yields identical results. Advances the MEOS vcpkg pin one commit over the base branch to d4cc7d289 so the mindistance kernels are present; that commit only adds mindistance_tgeo_tgeo and tgeoarr_tgeoarr_mindist and changes no existing signature.
estebanzimanyi
force-pushed
the
fix/bump-meos-pin
branch
from
45df2ad to
2067f2a
Compare
estebanzimanyi
force-pushed
the
feat/mindistance-udf-udaf-scaffold
branch
from
3051e8f to
f0b9b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers minDistance(tgeompoint, geometry), minDistance(geometry, tgeompoint), and minDistance(tgeompoint, tgeompoint) following the nearestApproachDistance pattern. The geo-typed forms reuse the NAD kernel since NAD reduces to spatial-min when one argument has no time dimension; the tgeompoint/tgeompoint form calls the threshold-aware mindistance_tgeo_tgeo kernel. The canonical cross-join shape is MIN(minDistance(t1, t2)) with GROUP BY, the cloud-SQL-natural Solution-2 form, identical in result to the MobilityDB 2-ary aggregate of the same signature. Stacked on the MEOS pin bump branch; advances the pin one further commit to d4cc7d289 so the mindistance kernels are present, a commit that only adds mindistance_tgeo_tgeo and tgeoarr_tgeoarr_mindist and changes no existing signature.