fix file upload endpoint#183
Merged
Merged
Conversation
NianJiuZst
approved these changes
Jul 14, 2026
NianJiuZst
left a comment
NianJiuZst
left a comment
Collaborator
There was a problem hiding this comment.
@minmax Thanks for your contribution! Approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the MiniMax file upload endpoint used by
mmx file uploadand the File SDK.The current endpoint is
/v1/files, which returns 404 against the public API. The documented and working upload endpoint is/v1/files/upload.Changes
fileUploadEndpoint()to use/v1/files/uploadVerification
bun test test/client/endpoints.test.ts test/commands/file/upload.test.ts test/sdk/file.test.tsbun run typecheckbun run buildNotes
I verified the failure manually with
mmx file upload, which POSTed to/v1/filesand received a 404. Posting the same multipart form to/v1/files/uploadsucceeds and returns afile.file_id.