Draft
Conversation
Technici4n
commented
Aug 3, 2024
|
|
||
| fun withJarJar() { | ||
| project.tasks.named<Jar>("jar") { | ||
| archiveClassifier.set("slim") |
Author
There was a problem hiding this comment.
Note: I removed this because MDG will add the jarjar stuff to the normal jar directly. It is possible to create a slim jar manually but it shouldn't be necessary.
| singleInstance() | ||
| create("server") { | ||
| server() | ||
| // TODO singleInstance() |
Author
There was a problem hiding this comment.
Not (yet) supported by MDG as far as I know. Does this only control the IDEA run? If so it should be trivial to add.
| return@guard if (hasProperty(it)) property(it)?.toString() else null | ||
| }) | ||
| fun Project.localGradleProperty(name: Provider<String>): Provider<String> = name | ||
| .filter { hasProperty(it) && property(it) != null } |
Author
There was a problem hiding this comment.
Note: Incubating API, but MDG uses it internally anyway and I don't see a good alternative that preserves nullability safety. (Otherwise we'd need a Provider<String?>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port to MDG. There are a few TODOs, nothing critical I think but it's worth having another look.
It would be good to also test this on a project that uses an API sourceset, datagen, and JIJ.