Goto GUI Performance Fix #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `.get()`, `.save()`, & `.getConfig()`. No need to set `@Excluded` on a static field.
Move "perspective" concept to `FreecamPosition`. Move `isInRange` to `FreecamPosition`.
Enables Freecam if not already. Teleports freecam to the specified `FreecamPosition`. Intended for use by "Goto GUI".
Adds a GUI which allows jumping freecam to a player within render distance. Limited on Modrinth to `MC.player`. Could be expanded in future with tripod locations and other "saved" positions.
The `Tab` implementation provides a method to produce a list of `TargetListEntries`. Currently, the only implementation is `PlayerTab`, which provides a list of `PlayerListEntries` & a "perspective" button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance of the GUI Screen "GotoScreen" from PR #116.
Performance measured:
Recorded on i7-14700k & RTX 2060 SUPER
Credit to @MattSturgeon for the original implementation in #116.