Skip to content

Fix CLI error handling and build metadata#7

Merged
BoySanic merged 3 commits into
MinecraftAtHome:mainfrom
mrzetti:fixes
Jun 22, 2026
Merged

Fix CLI error handling and build metadata#7
BoySanic merged 3 commits into
MinecraftAtHome:mainfrom
mrzetti:fixes

Conversation

@mrzetti

@mrzetti mrzetti commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
  • src/main.cpp: return main_inner() from main(), so parse/open errors exit nonzero.
  • src/main.cpp: added missing failure returns for invalid --client and --server.
  • src/main.cpp: added explicit return 0 at the end of main_inner().
  • src/gpu.cu: wrapped cudaFuncSetAttribute(...) in TRY_CUDA; (CUDA docs confirm it returns cudaError_t).
  • makefile: added missing source/header dependencies for libcubiomes.a and gpu.o.
  • .gitignore: added main and main.exe, since the documented build creates main.

Verification

  • make
  • ./main --definitely-invalid
  • ./main --client invalid-address
  • ./main --server invalid-address

@mrzetti

mrzetti commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

build will succeed after #1 is merged

@BoySanic BoySanic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think you're formatting a bunch of stuff needlessly (it doesn't even seem to change indentation or anything - maybe line endings?).

I'd like to see this revised so that only the lines you're actually changing are being changed, and not the surrounding lines.

Comment thread src/main.cpp
Comment thread src/main.cpp
Comment thread src/gpu.cu
Comment thread .gitignore Outdated
Comment thread src/main.cpp
@BoySanic BoySanic merged commit c979ba6 into MinecraftAtHome:main Jun 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants