Deduplicate GPU and CPU seed outputs#15
Open
mrzetti wants to merge 1 commit into
Open
Conversation
Contributor
|
I'm not really looking for a dedupe. I want to know why we have a duplicated result to begin with as it could be causing us to do duplicate work. |
DutChen18
requested changes
Jun 23, 2026
| h ^= std::hash<int32_t>{}(output.score) + 0x9e3779b97f4a7c15ULL + (h << 6) + (h >> 2); | ||
| return h; | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
should probably specialize std::hash<CpuOutput> instead of writing a custom hasher struct.
| }); | ||
| h_buffer.erase(std::unique(h_buffer.begin(), h_buffer.end(), [](const SeedPos &a, const SeedPos &b) { | ||
| return a.seed_index == b.seed_index && a.x == b.x && a.z == b.z; | ||
| }), h_buffer.end()); |
Member
There was a problem hiding this comment.
Should probably overload the comparison operators instead of using a lambda. There is a nice way to implement these by wrapping the members in a temporary tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10
Verification
make NO_GPU=1passed.make gpu.opassed.makepassed.Performance test needed to be safe!