Disaggregation of temporally coarse forecasts results in NaNs - #247
Disaggregation of temporally coarse forecasts results in NaNs#247jonasbhend wants to merge 3 commits into
Conversation
|
hi @jonasbhend, the code changes look good to me, but I'm not entirely sure I understand the problem. Is this issue affecting baselines or ML runs? can you provide a concrete example scenario that would trigger it? |
| existing = [p for p in all_paths if p.exists()] | ||
| missing = [p for p in all_paths if not p.exists()] | ||
| if missing: | ||
| LOG.debug( |
There was a problem hiding this comment.
should there be some way to distinguish "expected coarser resolution" from "unexpected missing data"? should this be LOG.warning instead of debug to avoid that real data problems go unnoticed?
The concrete example is this config with a forecaster and a temporal downscaler being evaluated side-by-side (something we have done before). With explicit aggregations (i.e. TOT_PREC1 and TOT_PREC6), this will result in an error for both the experiment and meteogram use cases: |
When disaggregating forecasts with 6hourly resolution to hourly, the necessary input data is not available. This PR fixes the default behaviour (error) to allow plotting of meteograms and dashboards for diverse datasets of forecasters (6-hourly) and temporal downscalers (1-hourly).
Summary of changes