Avoid extrapolation in nearest neighbour interpolation - #212
Open
jonasbhend wants to merge 6 commits into
Open
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When truth and forecast data are mapped, forecasts are extrapolated ad infinitum even if the forecast data covers only a subset of the domain. This is currently the case for INCA forecasts and the inner verification domain (aka most of the high-resolution domain). To avoid misinterpretation of evaluation results, we propose to suppress extrapolation and report missing values for regions that are not fully covered. This PR implements this change.
Spatial coverage fraction
To allow for varying number of stations with observations by parameter, we compute the missing value fraction as the number of non-missing forecast / obs pairs divided by the number of non-missing observations. Currently the missing-value-fraction threshold is set to zero, because in this framework, we don't expect any missing forecasts other than incomplete domain coverage, which should indeed be masked.
Summary of changes