chore: optimize batch account create#55
Merged
Merged
Conversation
| ...derivedAccount.options, | ||
| groupIndex: derivationIndex, | ||
| }, | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
we drop groupIndex when create account
as it is no longer use, redundant
and does not match the keyring account structure
and we didnt do migration for now, as the SNAP is still in DEV stage
| callback?: (account: StellarKeyringAccount) => Promise<void>, | ||
| ): Promise<StellarKeyringAccount> { | ||
| const accounts = await this.#accountsRepository.getAll(); | ||
| return this.#createAccountLock.runExclusive(async () => { |
Collaborator
Author
There was a problem hiding this comment.
we add lock on both single and multiple account create method, to make sure they are not calling at same time as the best effort to avoid racing condition
khanti42
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces a batched/concurrency-limited account creation path to avoid sequential per-index derivation and persistence, and adds a new async batching utility to support that flow in the Snap codebase.
Brenchmark:
23 accounts with optimize batch creation: ~81ms
23 accounts with normal batch creation: ~1200ms
References
Checklist