refactor!: move BlockTrackerPollingController to user-operation-controller - #9882
Open
mikesposito wants to merge 9 commits into
Open
refactor!: move BlockTrackerPollingController to user-operation-controller#9882mikesposito wants to merge 9 commits into
BlockTrackerPollingController to user-operation-controller#9882mikesposito wants to merge 9 commits into
Conversation
mikesposito
commented
Aug 14, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86cba3b. Configure here.
mcmire
reviewed
Aug 14, 2026
mikesposito
force-pushed
the
me/refactor/block-polling-tracker
branch
from
August 14, 2026 14:39
a07fc87 to
f3e9d36
Compare
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Member
Author
|
Adding the |
jpuri
previously approved these changes
Aug 14, 2026
4 tasks
jpuri
approved these changes
Aug 14, 2026
mikesposito
enabled auto-merge
August 14, 2026 15:22
mcmire
reviewed
Aug 14, 2026
Comment on lines
-1619
to
-1626
| "packages/polling-controller/src/BlockTrackerPollingController.test.ts": { | ||
| "@typescript-eslint/explicit-function-return-type": { | ||
| "count": 2 | ||
| }, | ||
| "no-restricted-syntax": { | ||
| "count": 1 | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
We might want to add 1 instance of explicit-function-return-type back, but for the user-operation-controller package. (If we're going to remove this package anyway, we don't need to fix this lint violation right now.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
BlockTrackerPollingControlleris being removed from@metamask/polling-controllerso that the package doesn't need to depend on@metamask/network-controller.The only consumer of the removed class is
@metamask/user-operation-controller, so it has been moved there (unexported) to leave the consumer unchanged.References
config-registry#9879 due to circular dependencyChecklist
Note
Medium Risk
Breaking public API removal may affect downstream packages; in-repo usage is confined to user-operation-controller with a straight import swap.
Overview
Breaking:
@metamask/polling-controllerno longer shipsBlockTrackerPollingController/BlockTrackerPollingControllerOnlyand drops its@metamask/network-controllerdependency (tsconfig and package graph updated accordingly).The block-tracker polling mixin now lives inside
@metamask/user-operation-controlleras a local module;PendingUserOperationTrackerimports it from there instead of from@metamask/polling-controller. That implementation pulls shared polling primitives (AbstractPollingControllerBaseMixin,getKey, and related types) from the polling package’s new public exports, so behavior for the sole in-repo consumer should stay the same.Docs/changelog and README dependency edges reflect the split; polling-controller eslint suppressions for the removed test file are dropped, and user-operation-controller coverage thresholds are relaxed slightly.
Reviewed by Cursor Bugbot for commit 21b92ae. Bugbot is set up for automated code reviews on this repo. Configure here.