feat(keyring-eth-money)!: remove signTransaction pass-through#521
Merged
feat(keyring-eth-money)!: remove signTransaction pass-through#521
Conversation
danroc
changed the title
danroc
force-pushed
the
remove-signTransaction-money-keyring
branch
from
554d2db to
8b47d56
Compare
danroc
changed the title
Remove signTransaction from MoneyKeyring and EvmSigner type. Money accounts do not need to sign transactions.
danroc
force-pushed
the
remove-signTransaction-money-keyring
branch
from
8b47d56 to
7dd8344
Compare
ccharly
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signTransactionpass-through method from MoneyKeyringEvmSignertype and rename toMoneySigner; the type was incorrectly exported and no longer represents a full EVM signerChanges
MoneyKeyring.signTransactionis no longer availableEvmSignerrenamed toMoneySigner, no longer exportedNote
Medium Risk
Medium risk because it makes a breaking API change by removing
MoneyKeyring.signTransactionand tightening the exposed signer surface, which can break downstream callers expecting transaction signing.Overview
BREAKING:
MoneyKeyringno longer exposessignTransaction, reflecting that Money accounts should not sign EVM transactions.The internal signer type is renamed from exported
EvmSignerto unexportedMoneySigner(and dropssignTransaction), and the corresponding delegation test and changelog are updated accordingly.Reviewed by Cursor Bugbot for commit 8d5b2d0. Bugbot is set up for automated code reviews on this repo. Configure here.