Repository navigation
Fix suite data parsing - #257
Merged
James Bruten (james-bruten-mo) merged 1 commit intoOct 6, 2026
Merged
Conversation
James Bruten (james-bruten-mo)
approved these changes
Oct 6, 2026
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
Now that the cylc install we're using is using a more recent version of python this is fine to be upgraded
James Bruten (james-bruten-mo)
merged commit Oct 6, 2026
e58cf2b
into
MetOffice:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: James Bruten (@james-bruten-mo)
We have some formatting issues in generated
trac.log- the groups are not parsed correctly. The issue is that the string contains spaces after the commas and potential single quotes inside the string, so simply stripping brackets/quotes from the entire string and then splitting by","leaves raw quotes and spaces attached to the inner elements, e.g.,['developer', 'ex1a_cce_um_safe_omp-seukv_noda_edgepert']becomes["developer'", " 'ex1a_cce_um_safe_omp-seukv_noda_edgepert"]Here, I have introduced a fix using Python's built-in
ast.literal_eval, which safely parses the string directly into a true Python list.Code Quality Checklist
Testing
Security Considerations
AI Assistance and Attribution
NA
Code Review