Skip to content

Styling omp - #256

Merged
Jenny Hickson (jennyhickson) merged 5 commits into
MetOffice:mainfrom
ericaneininger:styling_OMP
Oct 6, 2026
Merged

Jenny Hickson (jennyhickson) merged 5 commits into
MetOffice:mainfrom
ericaneininger:styling_OMP

Conversation

@ericaneininger

@ericaneininger Erica Neininger (ericaneininger) commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

PR Summary

LFRic styling keyword conversion to lowercase - update keyword list to include OMP directive keywords (except the sentinel itself): PARALLEL, SCHEDULE, STATIC, DYNAMIC, SHARED, NOWAIT

Sci/Tech Reviewer:
Code Reviewer: Jenny Hickson (@jennyhickson)

closes #255

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)
    Since I created this issue while reviewing Activation fix casim#19, I've run the large_scale _precipitation scheme science directory through, and keywords were updated in OMP directives in a total of 12 files.
    The only kewords converted, ina ddition to the targeted OMP directives, were a couple of case DEFAULT statements - which seemed reasonable.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Oct 1, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jennyhickson
Jenny Hickson (jennyhickson) merged commit c713f81 into MetOffice:main Oct 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OMP directives not captured as UPPERCASE keywords by lfric_styling

3 participants