Skip to content

build: fix warning about key in OptionsTable#10113

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/fix-warn/Iac5f82e5a0fcf1c06dd223db5c8e72949e9e9138
Feb 3, 2026
Merged

build: fix warning about key in OptionsTable#10113
mergify[bot] merged 1 commit intomainfrom
devs/jd/fix-warn/Iac5f82e5a0fcf1c06dd223db5c8e72949e9e9138

Conversation

@jd
Copy link
Member

@jd jd commented Feb 3, 2026

The issue was that the shorthand fragment syntax (<>...</>) doesn't support key props.

Copilot AI review requested due to automatic review settings February 3, 2026 12:25
@mergify mergify bot had a problem deploying to Mergify Merge Protections February 3, 2026 12:26 Failure
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a React warning by replacing the shorthand fragment syntax (<>...</>) with the explicit React.Fragment syntax to support the key prop in a mapped component.

Changes:

  • Added React import to enable React.Fragment usage
  • Replaced shorthand fragment syntax with React.Fragment key={optionKey} in the map function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The issue was that the shorthand fragment syntax (<>...</>) doesn't support key props.

Change-Id: Iac5f82e5a0fcf1c06dd223db5c8e72949e9e9138
@jd jd force-pushed the devs/jd/fix-warn/Iac5f82e5a0fcf1c06dd223db5c8e72949e9e9138 branch from 2371bc0 to 26565fe Compare February 3, 2026 13:06
@mergify mergify bot deployed to Mergify Merge Protections February 3, 2026 13:07 Active
@mergify mergify bot requested a review from a team February 3, 2026 13:08
mergify bot added a commit that referenced this pull request Feb 3, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2026

Merge Queue Status

✅ The pull request has been merged at 26565fe

This pull request spent 2 minutes 22 seconds in the queue, including 2 minutes 6 seconds running CI.
The checks were run on draft #10117.

Required conditions to merge

@mergify mergify bot added the queued label Feb 3, 2026
@mergify mergify bot merged commit 0ed6602 into main Feb 3, 2026
8 checks passed
@mergify mergify bot deleted the devs/jd/fix-warn/Iac5f82e5a0fcf1c06dd223db5c8e72949e9e9138 branch February 3, 2026 13:43
@mergify mergify bot removed the queued label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants