Conversation
cyanzhong
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds several reusable SharedUI components intended to support upcoming “extension manager” UI work, including table wrappers for SwiftUI/AppKit interoperability and a couple of standalone SwiftUI views.
Changes:
- Introduces
TableRowWrapper(AppKit) for drawing an inset hairline separator in table rows. - Introduces
TableCellWrapper(AppKit) for hosting arbitrary SwiftUI content insideNSTableCellView. - Adds two SwiftUI components:
LabeledProgressViewandPillButton.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MarkEditMac/Modules/Sources/SharedUI/TableRowWrapper.swift | New NSTableRowView subclass that lays out an inset divider/hairline separator. |
| MarkEditMac/Modules/Sources/SharedUI/TableCellWrapper.swift | New NSTableCellView subclass embedding an NSHostingView with horizontal (and current vertical) insets. |
| MarkEditMac/Modules/Sources/SharedUI/LabeledProgressView.swift | New SwiftUI progress indicator with a title and a reduce-motion-aware fade-in. |
| MarkEditMac/Modules/Sources/SharedUI/Buttons/PillButton.swift | New SwiftUI “pill” button supporting prominent vs bordered styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No consumers right now, will be used in upcoming PRs.