Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new app resources (SF Symbols identifiers + localized UI strings) needed for the upcoming Extension Manager feature, while intentionally leaving them unused for now to keep the PR series separated.
Changes:
- Added new SF Symbols identifiers to the shared
Iconscatalog. - Added new localized string constants for the Extension Manager UI surface.
- Added corresponding entries to
Localizable.xcstrings(including zh-Hans / zh-Hant translations).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MarkEditMac/Sources/Main/AppResources.swift | Extends the central SF Symbols name catalog with additional icons intended for Extension Manager UI. |
| MarkEditMac/Sources/Extension/ExtensionInstaller.swift | Adds new Localized.Extension string constants for forthcoming Extension Manager UI copy. |
| MarkEditMac/Resources/Localizable.xcstrings | Adds the localized string entries backing the newly introduced String(localized:) keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, new resources in PR have no references to them at all, which is part of the PR separation, as expected.