Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors extension update checking to decouple index refresh cadence from user-facing update prompt cadence, and adds core extension-management APIs (enable/disable, remove, reorder, uninstall) with corresponding tests.
Changes:
- Split extension registry behavior into background index revalidation (short TTL) vs. update prompt cadence, and track prompt satisfaction in cache metadata.
- Add extension-management operations in
ExtensionConfigplusExtensionDownloader.uninstall, and update the app updater flow to use a newdownloadUpdatehelper. - Expand
ExtensionCoreTeststo cover enable/disable, remove, reorder, and uninstall behaviors; renameExtensionEntryfieldscreenshots→colorPatterns.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MarkEditMac/Sources/Extension/ExtensionUpdater.swift | Adjusts update-check flow to refresh the registry index first, then gate prompts separately; updates update-application path to preserve user fields via new downloader API. |
| MarkEditMac/Modules/Tests/ExtensionCoreTests.swift | Adds tests for new extension config operations and uninstall behavior; updates entry construction for renamed registry fields. |
| MarkEditMac/Modules/Sources/ExtensionCore/ExtensionRegistry.swift | Introduces separate prompt cadence tracking (lastPrompted) and index revalidation TTL; renames ExtensionEntry field. |
| MarkEditMac/Modules/Sources/ExtensionCore/ExtensionDownloader.swift | Adds downloadUpdate helper and uninstall API to delete script + remove config record. |
| MarkEditMac/Modules/Sources/ExtensionCore/ExtensionConfig.swift | Adds setEnabled, remove, and reorder APIs; adds Installed.settingEnabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.