Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is the first step of the extension manager/package migration by renaming the AppKitControls SwiftPM library to SharedUI, updating app/module imports accordingly, and migrating UI components into the new SharedUI target.
Changes:
- Rename the SwiftPM product/target from
AppKitControlstoSharedUIand update consumers. - Update
MarkEditMacsources (and module code) to importSharedUIinstead ofAppKitControls. - Add new
SharedUIUI building blocks (buttons, effect/material views, find/goto-line UI, SwiftUI previews/spinners).
Reviewed changes
Copilot reviewed 16 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MarkEditMac/Sources/Panels/Replace/EditorReplaceTextField.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Panels/Replace/EditorReplaceButtons.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Panels/Find/EditorFindPanel.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Main/AppRuntimeConfig.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Views/EditorStatusView.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Views/EditorPanelView.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+UI.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+GotoLine.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+Config.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Modules/Tests/MaterialViewTests.swift | Update test target to @testable import SharedUI. |
| MarkEditMac/Modules/Sources/SharedUI/ThemePreview.swift | New SwiftUI theme swatch preview component. |
| MarkEditMac/Modules/Sources/SharedUI/SpinningRing.swift | New SwiftUI spinning progress indicator. |
| MarkEditMac/Modules/Sources/SharedUI/RoundedNavigateButtons.swift | New navigational button group wrapper. |
| MarkEditMac/Modules/Sources/SharedUI/RoundedButtonGroup.swift | New shared rounded button group control. |
| MarkEditMac/Modules/Sources/SharedUI/MaterialView.swift | New material/tint container view. |
| MarkEditMac/Modules/Sources/SharedUI/LabelView.swift | New shared label-like NSTextField subclass. |
| MarkEditMac/Modules/Sources/SharedUI/LabeledSearchField.swift | New custom search field with trailing label and modern icon rendering. |
| MarkEditMac/Modules/Sources/SharedUI/GotoLine/GotoLineWindow.swift | New borderless goto-line window wrapper. |
| MarkEditMac/Modules/Sources/SharedUI/GotoLine/GotoLineView.swift | New goto-line content view (effect view + icon + text field). |
| MarkEditMac/Modules/Sources/SharedUI/FocusTrackingView.swift | New focus tracking view utility. |
| MarkEditMac/Modules/Sources/SharedUI/EffectView.swift | New NSVisualEffectView subclass for blur-radius adjustment. |
| MarkEditMac/Modules/Sources/SharedUI/DividerView.swift | New divider view utility. |
| MarkEditMac/Modules/Sources/SharedUI/Buttons/TitleOnlyButton.swift | New title-only button built on shared label/button base. |
| MarkEditMac/Modules/Sources/SharedUI/Buttons/NonBezelButton.swift | New non-bezel button base with custom drawing/focus ring. |
| MarkEditMac/Modules/Sources/SharedUI/Buttons/IconOnlyButton.swift | New icon-only button built on shared button base. |
| MarkEditMac/Modules/Sources/SharedUI/Buttons/AquaFocusRingButton.swift | New legacy focus ring enhancement button. |
| MarkEditMac/Modules/Sources/SharedUI/BezelView.swift | New bezel drawing view replacement. |
| MarkEditMac/Modules/Sources/SharedUI/BackgroundTheming.swift | New protocol for propagating background colors to descendants. |
| MarkEditMac/Modules/Sources/FileVersion/FileVersionPicker.swift | Switch import from AppKitControls to SharedUI. |
| MarkEditMac/Modules/Package.swift | Rename product/target/path/dependencies from AppKitControls to SharedUI. |
| MarkEdit.xcodeproj/project.pbxproj | Update package product dependency from AppKitControls to SharedUI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.