Skip to content

Add explicit stack log print to core logger#2865

Merged
gerteck merged 2 commits intoMarkBind:masterfrom
gerteck:addStackLog
Mar 22, 2026
Merged

Add explicit stack log print to core logger#2865
gerteck merged 2 commits intoMarkBind:masterfrom
gerteck:addStackLog

Conversation

@gerteck
Copy link
Member

@gerteck gerteck commented Mar 22, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Just a quick addition to #2864, that i should have highlighted.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Add explicit stack log print to core logger


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the core winston console formatter to prefer printing an error’s stack trace (when available) instead of only the error message, improving debugging output in CLI logs (follow-up to #2864).

Changes:

  • Adjust console format.printf to output info.stack when present, falling back to info.message otherwise.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.99%. Comparing base (221b36e) to head (ba530ea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2865   +/-   ##
=======================================
  Coverage   71.99%   71.99%           
=======================================
  Files         132      132           
  Lines        7352     7352           
  Branches     1633     1570   -63     
=======================================
  Hits         5293     5293           
+ Misses       2053     1958   -95     
- Partials        6      101   +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gerteck gerteck merged commit 8e80ff8 into MarkBind:master Mar 22, 2026
10 checks passed
@gerteck gerteck deleted the addStackLog branch March 22, 2026 05:35
@github-actions github-actions bot added the r.Patch Version resolver: increment by 0.0.1 label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants