refactor: resolve tile keys in the tiles-deletion strategy (MAPCO-11269) - #39
Merged
Merged
Conversation
|
🎫 Related Jira Issue: MAPCO-11269 |
CL-SHLOMIKONCHA
requested changes
Sep 3, 2026
resolveTileKeyGenerator is a pure params -> generator function with no DI and no strategy state, so it does not belong under strategies/. Move it next to the generators it composes in utils/path.ts. Note this diverges from the ticket's stated design of adding keysForRange() to IStorageProvider: S3 and FS emit byte-identical keys, so the interface method would have two copy-pasted implementations, and REDIS has no provider to implement it until MAPCO-11263. Revisit when the Redis provider lands. No behaviour change.
CL-SHLOMIKONCHA
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11269
Further information:
Tile-key formatting moves from the storage providers to the tiles-deletion strategy:
IStorageProvider.keysForRangeis replaced byresolveTileKeyGenerator(cleaner/strategies/tileKeys.ts), which picks the generator bystorageProvider. No behaviour change — the emitted keys are identical.keysForRange, and theTilesDeletionParamsimport fromIStorageProvider.