Open
Conversation
Collaborator
tim-pearson
commented
Apr 16, 2026
tim-pearson
commented
- merged main branch to include advection convergence tests
- benchmarks for the vectorized kernals
tpadioleau
requested changes
Apr 17, 2026
Member
tpadioleau
left a comment
tpadioleau
left a comment
There was a problem hiding this comment.
First review more on the form than the content
| #include <euler_arrays.hpp> | ||
| #include <perfect_gas.hpp> | ||
|
|
||
|
|
| @@ -1,9 +1,12 @@ | |||
| #pragma once | |||
|
|
|||
|
|
|||
| #include <euler_arrays.hpp> | ||
| #include <perfect_gas.hpp> | ||
|
|
||
|
|
| #include "benchmark_utils.hpp" | ||
| #include "index_type.hpp" | ||
| #include "real_type.hpp" | ||
| #include "utils.hpp" |
Member
There was a problem hiding this comment.
Suggested change
| #include "utils.hpp" | |
| #include <utils.hpp> |
It is coming from -I/-isystem paths
Comment on lines
42
to
+43
| } | ||
| void ConsToPrimVectorized(benchmark::State& state) |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| void ConsToPrimVectorized(benchmark::State& state) | |
| } | |
| void ConsToPrimVectorized(benchmark::State& state) |
| @@ -0,0 +1,19 @@ | |||
|
|
|||
Comment on lines
+1
to
+2
| #pragma once | ||
| #include <Kokkos_Core.hpp> |
Member
There was a problem hiding this comment.
Suggested change
| #pragma once | |
| #include <Kokkos_Core.hpp> | |
| #pragma once | |
| #include <Kokkos_Core.hpp> |
| #pragma once | ||
| #include <Kokkos_Core.hpp> | ||
|
|
||
| #include "euler_arrays.hpp" |
Member
There was a problem hiding this comment.
Suggested change
| #include "euler_arrays.hpp" | |
| #include <euler_arrays.hpp> |
Comment on lines
+31
to
+33
|
|
||
|
|
||
|
|
|
|
||
| add_subdirectory(benchmarks) | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.