Update _bertopic.py to address #2316#2317
Open
nhansendev wants to merge 1 commit intoMaartenGr:masterfrom
Open
Update _bertopic.py to address #2316#2317nhansendev wants to merge 1 commit intoMaartenGr:masterfrom
nhansendev wants to merge 1 commit intoMaartenGr:masterfrom
Conversation
Added "embeddings" kwarg to update_topics for use when pre-calculated document embeddings are used. Addresses issue MaartenGr#2316
Author
|
The user could easily miss that they need to provide the embeddings to |
Owner
|
Might indeed be nice to have such a check here but I'm not sure whether it would cover all cases considering the |
Owner
|
I'm rerunning all jobs since the error didn't relate to your code but a connection issue with huggingface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "embeddings" kwarg to update_topics for use when pre-calculated document embeddings are used. Addresses issue #2316
What does this PR do?
Fixes #2316
Before submitting