Mute commenter's Conversation on a post when their last comment is de…#866
Open
ottocorrext wants to merge 1 commit into
Open
Mute commenter's Conversation on a post when their last comment is de…#866ottocorrext wants to merge 1 commit into
ottocorrext wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a commenter's only comment on a post is deleted, their Conversation row for that post isn't cleaned up, so the post keeps showing in their Conversations feed indefinitely. Issue deletion of comment doesn't take item out of "Conversation" view #706
After deleting a comment,
Comment.delete()now checks whether the commenter has any remaining comments on that post. If not, their Conversation gets muted. Follows the same pattern asSharedfile.delete()which already mutes conversations when a file is deleted. The file owner's Conversation is left alone regardless.Re-commenting after a deletion doesn't unmute. Muted state is shared with the manual mute UI so silently reversing it would override a deliberate user choice.