fix: guard QBMM boundary extrapolation with present(pb_in)#1332
Draft
sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
Draft
fix: guard QBMM boundary extrapolation with present(pb_in)#1332sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
sbryngelson wants to merge 1 commit intoMFlowCode:masterfrom
Conversation
f3bb4b6 to
167c10f
Compare
|
Claude Code Review Incremental review from: f3bb4b6 New findings since last Claude review:
|
5 tasks
post_process calls s_populate_variables_buffers without the optional pb_in/mv_in arguments, but the QBMM guard (qbmm .and. .not. polytropic) could still evaluate to true, causing access to an absent optional argument. This is undefined behavior caught by gfortran -fcheck=bounds. Add present(pb_in) to all 6 call sites of s_qbmm_extrapolation.
167c10f to
4ecd249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s_populate_variables_bufferswithout the optionalpb_in/mv_inarguments, but the QBMM guard (qbmm .and. .not. polytropic) could still evaluate to true, causing access to an absent optional argument — undefined behavior in Fortran.present(pb_in)to all 6 call sites ofs_qbmm_extrapolationinm_boundary_common.fpp.-fcheck=boundsin the macOS debug CI build.Test plan
./mfc.sh precheckpasses