Open
Conversation
Debraheem
added
documentation
Debraheem
requested review from
annethoul,
aurimontem,
evbauer,
fxt44,
mjoyceGR,
orlox,
rsmolec and
wmwolf
as code owners
Member
Author
|
Happy to hear objections to this change. The alternative to this pr is to add back the black body outer boundary condition, which I could see a case for. Otherwise, we should remove this machinery and consolidate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the discussion in #971. Tsurf_factor is deprecated. This pr removes Tsurf factor, its associated controls/references, and makes note of this in the changelog.