refactor: resource_team_id_query#3479
Merged
Merged
Conversation
msmithstubbs
force-pushed
the
refactor/resouce-team-id
branch
3 times, most recently
from
a8760aa to
2edb782
Compare
msmithstubbs
force-pushed
the
refactor/resouce-team-id
branch
from
2edb782 to
09eb20c
Compare
msmithstubbs
force-pushed
the
refactor/resouce-team-id
branch
3 times, most recently
from
9eff0a9 to
46f39b2
Compare
msmithstubbs
force-pushed
the
refactor/resouce-team-id
branch
3 times, most recently
from
45a1c10 to
7ee78f1
Compare
msmithstubbs
force-pushed
the
refactor/resouce-team-id
branch
from
7ee78f1 to
844e5c3
Compare
Ziinc
approved these changes
Jun 8, 2026
| html = submit_query_form(view, conn) | ||
|
|
||
| assert html =~ "Ran query successfully" | ||
| assert_patch(view) =~ ~s(t=#{other_team.id}) |
Contributor
There was a problem hiding this comment.
we should add in a small flash each time we switch teams as well. i think now flashes will stack on top of each other, would be good to have a more robust toast system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor followup on default team param PRs.
TeamContextReady to merge after: