fix: close the window from the last conversation tab - #866
Merged
Merged
Conversation
Model: gpt-6
wibus-wee
marked this pull request as ready for review
September 21, 2026 03:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Cmd/Ctrl+W in a Session window opened with modifier-click closed its sole conversation tab and left a draft instead of closing the window. The close resolver accepted but ignored the visible conversation tab count.
Summary
Yield to native window close when one conversation tab remains, including a child or draft, without changing shared Session closure state. Keep focused side-panel close priority, individual closure with multiple conversation tabs, and explicit tab × behavior. Update the bilingual window Spec and decision note, and extend the owning regression suite.
Visual explanation
Before / after
Test plan
git diff --check.pnpm check(tsgo),pnpm format(oxfmt), and targeted Vitest (vitest).pnpm run docs check: 34 pre-existing submodule link errors, no new errors.