Skip to content

fix: keep ACP authentication input runnable during login - #785

Draft
Dante-dan wants to merge 1 commit into
LodyAI:mainfrom
Dante-dan:fix/505-authentication-control-lanes
Draft

Dante-dan wants to merge 1 commit into
LodyAI:mainfrom
Dante-dan:fix/505-authentication-control-lanes

Conversation

@Dante-dan

@Dante-dan Dante-dan commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Related issue

Closes #505

Problem / pressure

Local ACP authentication starts and their input submissions share the default serial message queue. A login waits for a method selection while that selection waits behind the login, causing the submission timeout reported for Google Antigravity. Authorization-code submissions and cancellation have the same dependency.

Summary

Give each machine/authentication request separate start and follow-up execution lanes. Keep follow-up actions ordered with each other and preserve existing session queue behavior. Add deterministic regressions to the existing message processor suite and document the decision in both languages.

Visual explanation

Before: default lane = start (await input) → submit-input (cannot run)
After:  auth/request/start = start (await input)
        auth/request/input = submit-input / submit-code / cancel

Before / after

Before After
Login holds the queue needed to submit its selected method or authorization code. Follow-up requests execute while login is pending.
Cancellation waits behind the login it should cancel. Cancellation uses the follow-up lane.

Test plan

  • Existing message processor suite: 5 passed. The three new submit-input, submit-code, and cancel cases fail against the previous implementation and pass after the change.
  • Oxfmt check for both changed TypeScript files and git diff --check passed.
  • pnpm check failed during workspace typechecking because package dependencies are absent in this worktree (packages/ignore: missing Node/Vitest types). pnpm format failed because workspace Oxfmt was unavailable; the changed files were formatted and checked with the existing installed formatter. pnpm run docs check reported existing links into uninitialized ACP submodules.

Context handoff

Original user prompt

Show original prompt
请跟进对应的 issue: xxx , 并注意 xxxx 内容

Delegated task scope

The user authorized filling the issue and focus placeholders in the template above. The resulting task scope, filled by the assistant, is: follow #505, fix local authentication input being queued behind the login waiting for it, preserve existing ACP and session ordering behavior, and run the repository checks.

Shared conversation

Status: unavailable
Reason: This authoring environment does not provide a public HTTP(S) conversation URL. No private conversation content is included in this PR.

@github-actions github-actions Bot added scope: cli status:needs-pr-attention External PR needs contributor attention before review and removed status:needs-pr-attention External PR needs contributor attention before review labels Sep 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Google Antigravity sign-in gets stuck after selecting Log in with Google

1 participant