Skip to content

fix review findings and additional clean up#116

Merged
iamleonie merged 3 commits into
mainfrom
lm/review-findings-guides
Jul 14, 2026
Merged

fix review findings and additional clean up#116
iamleonie merged 3 commits into
mainfrom
lm/review-findings-guides

Conversation

@iamleonie

Copy link
Copy Markdown
Contributor
  • Addressed post-merge review feedback on the migration guide.
  • Simplified runtime guidance into GPU inference and edge/on-device deployment links. (Didn't contain much migration specific details)
  • Reworked migration guide sections for clearer navigation: Deployment runtimes, Chat Template, Sampling Configuration, Tool Use, and Fine-tuning.
  • Added section-level links from the intro and moved main documentation references to the bottom of each section.
  • Clarified sampling guidance and linked to the Prompting Guide for per-model recommendations.
  • Standardized tool-use guidance around the lfm2 parser and native Pythonic tool-call format. (confirmed its called lfm2 parser
  • Added reusable snippets for shared ChatML and tool-call examples.
  • Removed duplicated fine-tuning stack details and linked to the canonical fine-tuning docs.

@mintlify

mintlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
liquid-docs 🟢 Ready View Preview Jul 10, 2026, 3:38 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Comment thread guides/migration-guide.mdx Outdated
Comment thread guides/migration-guide.mdx Outdated
Comment thread guides/migration-guide.mdx Outdated
| Qwen3-4B/8B, Llama-3.1-8B, Gemma-3-12B | [LFM2.5-8B-A1B](https://huggingface.co/LiquidAI/LFM2.5-8B-A1B) | MoE with 8B total and 1.5B active parameters. |
| Qwen3-14B/32B and larger dense models | [LFM2-24B-A2B](https://huggingface.co/LiquidAI/LFM2-24B-A2B) | 24B total and roughly 2.3B active parameters. |
| Qwen3 thinking mode or DeepSeek distills | [LFM2.5-1.2B-Thinking](https://huggingface.co/LiquidAI/LFM2.5-1.2B-Thinking) | Reasoning traces at 1.2B. |
| Qwen3-0.6B, Llama-3.2-1B, Gemma-3-270M/1B | [LFM2.5-230M](https://huggingface.co/LiquidAI/LFM2.5-230M) or [LFM2.5-350M](https://huggingface.co/LiquidAI/LFM2.5-350M) | Smallest text models for classification, extraction, routing, and tight memory budgets. |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we're talking about Qwen3 and Gemma 3 instead of Qwen3.5 and Gemma 4 everywhere. We should probably either update it when there's a clear replacement or have both when there's none (particularly true for Gemma 4).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reduce maintenance efforts for the future, i decided to remove all direct model IDs and replace them with more generic categories.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamleonie good take, agree

@EdoardoMosca

Copy link
Copy Markdown
Contributor

content LGTM 🟢
i also checked that Mintify renders the changed pages correctly 🟢

nit: you have a few trailing spaces flagged by git diff --check main...HEAD, i will fix those in a sec

so good to go IMO

@EdoardoMosca
EdoardoMosca removed the request for review from alay2shah July 14, 2026 17:23
@EdoardoMosca

Copy link
Copy Markdown
Contributor

removed @alay2shah as reviewer since he's OOO

@EdoardoMosca EdoardoMosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments in line in PR

can merge IMO

@iamleonie
iamleonie merged commit 3e39588 into main Jul 14, 2026
7 checks passed
@iamleonie
iamleonie deleted the lm/review-findings-guides branch July 14, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants