Repository navigation
fix: fix accessing atest web pages err - #872
Merged
Merged
Conversation
yuluo-yx
commented
Apr 3, 2026
Collaborator
- Fixed Running via Docker results in an error when accessing the web page. #871
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
|
|
There are 1 test cases, failed count 0:
Reported by api-testing. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 5 (≤ 20 complexity) |
TIP This summary will be updated as you push new changes. Give us feedback
LinuxSuRen
approved these changes
Oct 9, 2026
LinuxSuRen
left a comment
Owner
There was a problem hiding this comment.
Approve ✅ — verified locally and via CI.
Root cause & fix are correct. On a fresh install without data/core/extension.yaml, GetStoreKinds propagated the os.ReadFile error, which made the GetStores/GetStoreKinds RPCs fail and broke the web console. Treating only os.IsNotExist as "no extensions configured" (while still surfacing permission errors and YAML parse errors) is the right behavior.
Verification
- Ran
go test ./pkg/testing/on this branch locally: all pass, including the two new subtests. - CI at head is green (Build / Test / E2E / BuildEmbedUI / BuildDesktop on all OSes).
- The
go.sumcleanup is fine:go.modpinslinuxsuren/go-service v0.0.2; the removed pseudo-version entry was stale. - New coverage at both levels (unit
store_test.go+ server-levelremote_server_test.go) — nice.
Non-blocking nits
- Consider
errors.Is(err, fs.ErrNotExist)instead ofos.IsNotExistfor modern style. getRemoteServerInTempDirWithoutExtensionsduplicates most ofgetRemoteServerInTempDir; could share a helper with a flag.- SonarCloud quality gate is red (coverage on new code) — not blocking from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

