Skip to content

Upgrade @rubensworks/eslint-config 1.2.0 → 3.1.0 with flat config migration#168

Merged
rubensworks merged 10 commits intomasterfrom
copilot/continue-pull-138-work
Apr 3, 2026
Merged

Upgrade @rubensworks/eslint-config 1.2.0 → 3.1.0 with flat config migration#168
rubensworks merged 10 commits intomasterfrom
copilot/continue-pull-138-work

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

  • Diagnose CI failure: webpack web build fails due to node:fs, node:path, node:stream UnhandledSchemeError and two TypeScript errors in test-web.ts
  • Fix test-web.ts: moved // @ts-expect-error from before the import (unused → TS2578) to right before globalThis.window = globalThis; (where TS error actually occurs)
  • Fix webpack.config-web.js: added NormalModuleReplacementPlugin to strip node: prefix so existing NodePolyfillPlugin handles polyfills (covers node:fs, node:path, node:stream from lib files)

Copilot AI and others added 2 commits April 3, 2026 06:52
- Rename type parameters Instance→TInstance, I→TI, HR→THR
- Rename ARGS_HANDLERS→argsHandlers, XSD_INHERITANCE_TABLE→xsdInheritanceTable
- Rename CJS_MAJOR_VERSION/CONTEXT_URL/etc to camelCase in PrefetchedDocumentLoader
- Change import x = require() to ES imports throughout
- Change || to ?? (nullish coalescing) where applicable
- Rename unused params to _-prefixed names
- Add eslint-disable-next-line ts/naming-convention for @type and URL keys
- Fix template literal array interpolations to use .join(', ')

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
…lization, missing logger.error, async build mock

Agent-Logs-Url: https://github.com/LinkedSoftwareDependencies/Components.js/sessions/06c889bf-188e-4910-9936-09a22f958cee

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 3, 2026

Pull Request Test Coverage Report for Build 23946569447

Details

  • 77 of 77 (100.0%) changed or added relevant lines in 25 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 23936378842: 0.0%
Covered Lines: 1523
Relevant Lines: 1523

💛 - Coveralls

@@ -0,0 +1,362 @@

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these eslint-*.txt files from the PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 1322caf.

Copilot AI requested a review from rubensworks April 3, 2026 12:43
@rubensworks rubensworks marked this pull request as ready for review April 3, 2026 12:52
@rubensworks rubensworks merged commit a4d841d into master Apr 3, 2026
24 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants