fix: stabilize README screenshot rendering - #121
Merged
Merged
Conversation
README screenshot check failedThe generated README screenshot differs from the committed version. Expected
Generated
Diff
If the visual change is expected, run |
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
fix/deterministic-readme-screenshot
branch
from
September 22, 2026 00:53
021d259 to
7315bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces false positives in the README screenshot check without increasing the pixel tolerance.
The screenshot generator now waits for web fonts to be ready, waits for two animation frames after the final UI state, and disables animations during capture.
This is based on the failure observed in #119, where the same pinned Playwright image produced a 0.7136% visual difference even though the PR only changed
@types/node.The existing 0.1% tolerance is intentionally kept unchanged so real visual regressions are not hidden.