fix: append extensions to midi and mp3 download filenames#170
Open
Blazzycrafter wants to merge 1 commit into
Open
fix: append extensions to midi and mp3 download filenames#170Blazzycrafter wants to merge 1 commit into
Blazzycrafter wants to merge 1 commit into
Conversation
Author
|
I ran CodeRabbit CLI locally on this branch, and it reported no findings or issues. The changes are clean and ready. |
Author
|
checked and change works..... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves an issue where downloaded MIDI and MP3 files were saved without their respective file extensions (
.midand.mp3).The Problem
Previously, in
src/main.ts, theBtnAction.downloadhelper was called withscoreinfo.fileNameas the target filename parameter for both MIDI and MP3 downloads. Becausescoreinfo.fileNameonly returns the sanitized title of the sheet music without any file extension, the browser saved these files without an extension (e.g., asSong_Titleinstead ofSong_Title.mid).Unlike PDF downloads (where the
.pdfextension is explicitly appended during the export process insrc/pdf.ts), no file extension handling was present for the direct MIDI and MP3 downloads.The Solution
We appended the missing
.midand.mp3file extensions to the filename arguments in theBtnAction.downloadcalls insrc/main.ts:+ ".mid"to the MIDI download button action.+ ".mp3"to the MP3 download button action.This ensures that the browser automatically saves the files with their correct extensions, preventing users from having to manually rename the downloaded files to open them.
Changes
In
src/main.ts: