Skip to content

Consistency tests#207

Open
pauladkisson wants to merge 250 commits intodevfrom
consistency_tests
Open

Consistency tests#207
pauladkisson wants to merge 250 commits intodevfrom
consistency_tests

Conversation

@pauladkisson
Copy link
Collaborator

@pauladkisson pauladkisson commented Feb 13, 2026

Depends on #191

Fixes #206

Branches of the pipeline to test:

  • combine data
  • artifact removal
  • z_score_method
  • isosbestic control
  • compute cross correlation
    • The cross-correlation option actually fails on the v1.3.0 (at least on Mac) because the spec file specifies Python 3.6 and scipy 1.5. However, the scipy.signal.correlation_lags function wasn't introduced to scipy until version 1.6, which requires Python 3.7+.
    • To cover this case, I added an integration test rather than a consistency test.
  • average group
  • dff instead of z-score for step 5

This PR also fixes the following bugs that were revealed by the consistency tests:

  • When combine_data = True, corrected_timestamps were incorrectly assigned to the ttl_timestamps. Now the TTL timestamps are computed properly.
  • When combine_data = True, combine_storesList.csv was not created. Now it is.

Base automatically changed from frontend to dev February 27, 2026 17:51
@pauladkisson pauladkisson marked this pull request as ready for review February 27, 2026 18:52
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 60.46512% with 85 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/guppy/testing/consistency.py 57.14% 57 Missing and 15 partials ⚠️
src/guppy/orchestration/preprocess.py 40.00% 4 Missing and 5 partials ⚠️
src/guppy/orchestration/transients.py 20.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistency Tests

1 participant