feat: add doctrine/dbal DateType#907
feat: add doctrine/dbal DateType#907Marcin Michalski (marmichalski) wants to merge 2 commits intomasterfrom
doctrine/dbal DateType#907Conversation
d5af50b to
b4363c9
Compare
|
My first personal impression is that we should use a separate repository for storage type mappings. Lendable doctrine types would focus on single purpose and we could focus here on date without storage dependencies. Feel free to ignore my comment or share your ideas. |
Martin Georgiev (martin-georgiev)
left a comment
There was a problem hiding this comment.
Can you extend the tests to validate against postgresql too, please?
|
Marcin Michalski (@marmichalski) gentle nudge |
Would likely make sense to have a types repository for each project, eg
Testing multiple platforms for this Type does not really matter as the cocnrete platform is not used for anything much, plus those are just unit tests, platform could just as well be a test double.
I will close this for now as I am not sure |
No description provided.