Conversation
cwwalter
reviewed
Mar 23, 2026
Member
cwwalter
left a comment
cwwalter
left a comment
There was a problem hiding this comment.
I don't see any code that changes the filename to the new extracted library.
Was it not checked in?
Collaborator
Author
Oh, good point. I forgot to make that change. I'll fix that.... |
jchiang87
force-pushed
the
u/jchiang/LSSTCam_cosmic_rays
branch
from
d58c612 to
8ae3975
Compare
Collaborator
Author
|
I made the new cosmic ray library the default and reran the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a new library based on LSSTCam dark frames from 2026-01-03. I've removed the old cosmic ray extraction code and wrote a new package that uses the Rubin tooling for cosmic ray detection. This is described at the wiki for the new package.