Skip to content

update skyCatalogs version; remove redundant package installs#505

Merged
jchiang87 merged 3 commits intomainfrom
u/jchiang/fix_docker_build
Mar 23, 2026
Merged

update skyCatalogs version; remove redundant package installs#505
jchiang87 merged 3 commits intomainfrom
u/jchiang/fix_docker_build

Conversation

@jchiang87
Copy link
Copy Markdown
Collaborator

Noting that the prebuilt lsst docker images now include batoid and batoid-rubin.

@jchiang87 jchiang87 marked this pull request as ready for review December 19, 2025 02:16
@jchiang87 jchiang87 force-pushed the u/jchiang/fix_docker_build branch from d58f0e4 to 33eb508 Compare March 4, 2026 23:38
Copy link
Copy Markdown
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the extent I understand the GitHub CI this LGTM.

Two notes just in case:

I remember that @jmeyers314 added that gitpython entry to fix some really hard to understand problem. Unfortunately, I can't remember what it was now...

It looks like this takes out all batoid installs? Do they get pulled in another way?

Copy link
Copy Markdown
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally didn't approve.

@jchiang87
Copy link
Copy Markdown
Collaborator Author

It looks like this takes out all batoid installs? Do they get pulled in another way?

I see them in the docker images made by Rubin:

>>> import batoid
>>> import batoid_rubin
>>> batoid
<module 'batoid' from '/opt/lsst/software/stack/conda/envs/lsst-scipipe-12.1.0/lib/python3.13/site-packages/batoid/__init__.py'>
>>> batoid_rubin
<module 'batoid_rubin' from '/opt/lsst/software/stack/conda/envs/lsst-scipipe-12.1.0/lib/python3.13/site-packages/batoid_rubin/__init__.py'>
>>> 

I remember that @jmeyers314 added that gitpython entry to fix some really hard to understand problem. Unfortunately, I can't remember what it was now...

I seem to recall it being related to a skyCatalogs problem....anyway, that also seems to be in the docker image:

>>> import git
>>> git
<module 'git' from '/opt/lsst/software/stack/conda/envs/lsst-scipipe-12.1.0/lib/python3.13/site-packages/git/__init__.py'>
>>> 

@cwwalter
Copy link
Copy Markdown
Member

cwwalter commented Mar 23, 2026

Sorry I see you noted the batoid dependency in the beginning of the conversation. I was just looking at the files.

@jchiang87 jchiang87 merged commit 240884e into main Mar 23, 2026
3 checks passed
@jchiang87 jchiang87 deleted the u/jchiang/fix_docker_build branch March 23, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants