fix(action): set cache-dependency-path to action's pyproject.toml - #5
Merged
Merged
Conversation
setup-python cache: pip searches the caller's workspace for requirements.txt or pyproject.toml by default. Consumer repos that aren't Python projects don't have these files, causing the action to fail. Explicitly pointing cache-dependency-path to the action's own pyproject.toml ensures caching always works regardless of the caller's repo structure. Made-with: Bunny
cache: pip requires a requirements file in the workspace. When the action is tested locally with uses: ./, github.action_path contains relative path components that cache-dependency-path rejects. The pip install is fast enough that caching adds no meaningful value. Made-with: Bunny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-pythonwithcache: pipsearches the caller's workspace forrequirements.txtorpyproject.tomlby default — those files don't exist in non-Python reposcache-dependency-pathto${{ github.action_path }}/pyproject.tomlso caching always resolves to the action's own dependency fileTest plan
pr-changesjob should passBunny helped with this PR and is one step closer to world domination...