Skip to content

[Fix] metadata updates after testing#262

Merged
HeyItsBATMAN merged 5 commits into
Kompakkt:mainfrom
vmalieske:hotfix_newMetadata
Jul 13, 2026
Merged

[Fix] metadata updates after testing#262
HeyItsBATMAN merged 5 commits into
Kompakkt:mainfrom
vmalieske:hotfix_newMetadata

Conversation

@vmalieske

@vmalieske vmalieske commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Metadata-bugs from #265 .
Addition:

  • issue with dialog-windows
  • renaming between upload and editing

@vmalieske vmalieske marked this pull request as draft June 19, 2026 13:38
@vmalieske vmalieske force-pushed the hotfix_newMetadata branch 2 times, most recently from 112f636 to 12a9888 Compare July 1, 2026 18:55
Part of Kompakkt#265 : add a string to switch naming between upload and edit an object
- close login-dialog when another dialog is opened
- move auth-dialog to dialog-folder so it's easier to find
- clean up ununsed imports and run format in register dialog
- change availableRoles to signal to serve the reactivity when adding a new role to the array
- distinguish between one and two buttons on optional cards
@vmalieske vmalieske force-pushed the hotfix_newMetadata branch from 4251b6c to 1ee0459 Compare July 12, 2026 17:11
@vmalieske vmalieske requested a review from HeyItsBATMAN July 12, 2026 17:18
@vmalieske vmalieske marked this pull request as ready for review July 12, 2026 17:18

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now, but we could switch to Angular Signal Forms and replace some getters with computed-signals instead.

@HeyItsBATMAN HeyItsBATMAN merged commit 5608282 into Kompakkt:main Jul 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants