Fix updateSegment function proxy the segments js object#839
Merged
PaulHax merged 1 commit intoKitware:mainfrom Jan 12, 2026
Merged
Fix updateSegment function proxy the segments js object#839PaulHax merged 1 commit intoKitware:mainfrom
PaulHax merged 1 commit intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Nice find. Thank you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
segmentGroupStore.updateSegmentfunction some how makes themetadata.segments.byValue.colorfield a proxy array.Steps to reproduce: click the [Lock] or [Hide] toggle button, which calls the

updateSegmentfunction:then, this object becomes proxied:
This leads to errors in below scenarios:
structuredClonepostMessage