Skip to content

encoder: default msbShift for >8-bit input #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crmurillo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

encoder: default msbShift for >8-bit input #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/encode_samples.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@
"profile": "main10",
"extra_args": [
"--inputBpp",
"10"
"10",
"--msbShift",
"6"
],
"description": "Test H.265 Main10 profile encoding",
"width": 352,
Expand Down Expand Up @@ -251,7 +253,9 @@
"profile": "main",
"extra_args": [
"--inputBpp",
"10"
"10",
"--msbShift",
"6"
],
"description": "Test AV1 Main profile 10-bit encoding",
"width": 352,
Expand Down
4 changes: 4 additions & 0 deletions vk_video_encoder/libs/VkVideoEncoder/VkEncoderConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,10 @@ int EncoderConfig::ParseArguments(int argc, const char *argv[])
return -1;
}

if (input.msbShift < 0 && input.bpp > 8) {
input.msbShift = static_cast<int8_t>(16 - input.bpp);
}

frameCount = inputFileHandler.GetFrameCount(input.width, input.height, input.bpp, input.chromaSubsampling);

if (numFrames == 0 || numFrames > frameCount) {
Expand Down
Loading