Added KHRCreateRenderpass2ExtensionName to requiredDeviceExtension to… #266
Conversation
… satisfy VUID-VkShaderModuleCreateInfo-pCode-08740
| vk::PipelineShaderStageCreateInfo shaderStages[] = {vertShaderStageInfo, fragShaderStageInfo}; | ||
| ---- | ||
|
|
||
| Finish by adding DrawParameters to the deviceExtensions. Otherwise the |
There was a problem hiding this comment.
That's not a good explanation. Can you rephrase this so people understand why this is required when using Slang?
There was a problem hiding this comment.
Barely :-) I've just started learning Vulkan - working through the tutorial, fixing things here and there to get it working.
As far as I can understand the SPIR compiler sets a flag or something in the bytecode signaling it's using parameters (though I don't see any at the moment). This cause the validation layer to complain the vk::KHRShaderDrawParametersExtensionName must be added.
What I can offer is to do some more research and come up with a better explanation. However, I can't make it tonight.
There was a problem hiding this comment.
Might be better to open issues for stuff like that instead. We'll then take a look and add a proper explanation.
There was a problem hiding this comment.
OK, I'll cancel this PR.
attachments/09_shader_modules.cpp
Outdated
| vk::KHRSpirv14ExtensionName, | ||
| vk::KHRSynchronization2ExtensionName, | ||
| vk::KHRCreateRenderpass2ExtensionName}; | ||
| vk::KHRCreateRenderpass2ExtensionName, |
There was a problem hiding this comment.
Only VK_KHR_shader_draw_parameters should be required. I don't think we need renderpass2 as that's core since 1.2 and we use 1.4.
There was a problem hiding this comment.
I can remove it, however it was there originally. I'll test if the validation layer complains.
There was a problem hiding this comment.
Sry my bad. If it was there, just leave it in place. I'm addressing extensions in #260
….2 and we use 1.4
2 participants
This fixes a warning from the validation layer when the shaders are added. The warning was:
I've added the extension to all example code from that step forward as I expect it'll be required in them all.