Repository navigation
Fix React duplicate-key errors in Radio editor tests - #4512
Merged
Merged
Conversation
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Contributor
|
Size Change: 0 B Total Size: 492 kB ℹ️ View Unchanged
|
jeremywiebe
approved these changes
Nov 6, 2026
handeyeco
pushed a commit
that referenced
this pull request
Nov 10, 2026
## Summary: We were rendering multiple Radio choices with the same key because our test setup set the same `id` on every choice. We now provide a unique ID to each choice. Issue: LEMS-4703 ## Test plan: `pnpm test 2>&1 | grep 'Encountered two children with the same key'` should not output anything. Author: benchristel Reviewers: jeremywiebe, anakaren-rojas Required Reviewers: Approved By: jeremywiebe Checks: ✅ 11 checks were successful, ⏭️ 4 checks have been skipped Pull Request URL: #4512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We were rendering multiple Radio choices with the same key because our test
setup set the same
idon every choice. We now provide a unique ID to eachchoice.
Issue: LEMS-4703
Test plan:
pnpm test 2>&1 | grep 'Encountered two children with the same key'should notoutput anything.