Keep working notes out of the source distribution - #89
Merged
Conversation
The exclude named a plan file that no longer exists, while a newer one was shipping: hatchling takes every file the VCS does not ignore, and these notes are deliberately untracked rather than ignored. A pattern covers both.
|
The author of this PR, mmshad, is not an activated member of this organization on Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sdist exclude named me-tui-plan.md, which is no longer in the tree, so the entry
looked like dead housekeeping. Building the sdist showed the opposite problem: a
newer working note, enhancements-aug-4-plan.md, was being shipped.
Hatchling takes every file the VCS does not ignore, and these notes are deliberately
untracked rather than gitignored, so each one has to be excluded or it lands in the
distribution. A pattern covers the one that exists and any later one.
Verified by building before and after: the sdist loses exactly that file, 189 entries
to 188, and still carries pyproject, the README, CONTRIBUTING, src, tests, docs and
the command index. The wheel was never affected, since it ships the package alone.