chore: remove dead code — unused/unimportable files and directories - #1055
Open
ilayfalach wants to merge 1 commit into
Open
chore: remove dead code — unused/unimportable files and directories#1055ilayfalach wants to merge 1 commit into
ilayfalach wants to merge 1 commit into
Conversation
Deletes seven dead files/directories confirmed via repo-wide grep to have zero references outside their own definitions, and/or hard syntax errors making them unimportable: - hera/simulations/utils/interpolation/ — broken duplicate (TabError) of the live hera/simulations/utils/interpolations.py - hera/simulations/LSM/hermesWorkflowToolkit.py — stale diverged fork of hera/simulations/hermesWorkflowToolkit.py - hera/simulations/openFoam/postProcess/VTKPipelineExecutionContext.py — unreferenced class + dangling functions - hera/simulations/openFoam/preprocessOFObjects/OFList.py — imported but never instantiated; internally broken. Also removes the now-dangling `from .OFList import OFList` line from preprocessOFObjects/__init__.py - hera/simulations/openFoam/toberewritten/netcdf2of.py — hard SyntaxError - hera/simulations/openFoam/toberewritten/xarrayDataset2OF.py — hard TabError/IndentationError - hera/measurements/GIS/raster/hill2stl.py — import-time side effect (writes test1.stl to disk), zero references Verified via python3 -m py_compile / ast.parse that neighboring __init__.py files and modules still import cleanly after these removals. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes 7 files/directories confirmed to have zero references anywhere in the repo, or that contain hard syntax errors and cannot be imported at all (
netcdf2of.py,xarrayDataset2OF.py). Includes a duplicate-of-a-live-module directory (simulations/utils/interpolation/), a stale diverged fork (LSM/hermesWorkflowToolkit.py), and an import-time side-effect file that writes to disk on import (GIS/raster/hill2stl.py).9 files changed, 2,769 deletions. Full detail in the "2. remove-dead-files" section of #1022.
Verification:
python3 -m py_compileon all touched/neighboring files; confirmed no remaining imports of deleted module paths anywhere in the repo.Refs #1022