Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72ebc4a2be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| default: () => { | ||
| // TODO 페이지 문구로 띄워주기 | ||
| toast.error(BOARD.error.readCondition); | ||
| // toast.error(BOARD.error.readCondition); | ||
| }, |
There was a problem hiding this comment.
This change makes the 400 handler a no-op, so when GET /posts/:id fails because the user has not met the read condition, useGetEachPostQuery now swallows the error completely. BoardView only special-cases 404, so these users are left on an empty page with no toast or inline explanation. Any board that relies on BOARD.error.readCondition will now fail silently.
Useful? React with 👍 / 👎.
| if (process.env.ANALYZE === 'true') { | ||
| chain | ||
| .plugin('bundle-analyzer') | ||
| .use(BundleAnalyzerPlugin, [{ analyzerMode: 'server' }]); |
There was a problem hiding this comment.
With analyzerMode: 'server', the new npm run build:analyze command will keep the analyzer HTTP server alive after the build finishes instead of exiting. Rsbuild documents this behavior explicitly, so anyone running the script in automation or expecting a one-shot report will see a hung process. The safer default here is the static report mode that terminates normally.
Useful? React with 👍 / 👎.
2 participants
No description provided.