cors/csrf/시간#13
Conversation
|
@codex review |
kem0-kem
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88d41234a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd5ae7678d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| attendanceService.create(member.getId()); | ||
| return ResponseEntity.ok(attendanceService.getTodayAttendancePoint(member)); |
There was a problem hiding this comment.
createTodayAttendance performs a write and then an immediate read, but the write path (AttendanceService.create) and read path (AttendanceService.getTodayAttendancePoint) each call now separately; if the request crosses midnight between these calls, the attendance can be saved for day N and read for day N+1, causing a false ATTENDANCE_NOT_FOUND right after successful creation. Capture a single date/time once in this endpoint flow (or return created data directly) to avoid the midnight boundary failure.
Useful? React with 👍 / 👎.
|
프론트 개발 서버에서 프록시 쓰면 해결되서 localhost cors는 허용할 필요는 없을 것 같습니다. |
|
To use Codex here, create a Codex account and connect to github. |
로컬호스트 뺐습니다. |
|
split attendance creation flow는 뭘 수정하신거에요? |
2 participants
cors/csrf/시간