Change all uses of wts to weights #570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/deploydoc
branch
5 times, most recently
from
77f53df to
43f7546
Compare
Member
|
Thanks for this. Could you add a deprecation for the |
Member
|
Also, if we want to release 2.0 quickly so that #487 may not be merged yet, it would be good to have this PR require |
Member
Author
Member
Member
|
Actually I'm preparing a PR which also allows passing the name of a column as weights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350
I've also removed some outdated developer comments instead of updating names of functions that no longer exist. I'm opening this PR against the PR that fixes the doc build on Julia 1.11 to make tests pass. GitHub will automatically change the target branch to master once #569 has been merged.