More robustly use effect override internals#116
Open
Keno wants to merge 1 commit intoJuliaSIMD:masterfrom
Open
More robustly use effect override internals#116Keno wants to merge 1 commit intoJuliaSIMD:masterfrom
Keno wants to merge 1 commit intoJuliaSIMD:masterfrom
Conversation
The effect override ABI is unstable. The current way it's being used is somewhat problematic: In release mode, it may silently stop working or apply the wrong effects and in debug mode it asserts. Instead, use the julia-level APIs, which have keyword arg constructors that are slightly more stable and will at least error consistently.
Contributor
Author
on CI, looks like it may be a JET issue? |
aviatesk
approved these changes
Nov 19, 2024
aviatesk
left a comment
There was a problem hiding this comment.
Which CI are you referring to? That error should be resolved in the latest version of JET.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The effect override ABI is unstable. The current way it's being used is somewhat problematic: In release mode, it may silently stop working or apply the wrong effects and in debug mode it asserts. Instead, use the julia-level APIs, which have keyword arg constructors that are slightly more stable and will at least error consistently.