Skip to content

Drop old version checking#494

Merged
dlfivefifty merged 5 commits intomasterfrom
Drop-old-version-checking
Dec 18, 2025
Merged

Drop old version checking#494
dlfivefifty merged 5 commits intomasterfrom
Drop-old-version-checking

Conversation

@dlfivefifty
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (6ccbdd8) to head (650d3b2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   90.00%   90.13%   +0.12%     
==========================================
  Files          27       27              
  Lines        3742     3740       -2     
==========================================
+ Hits         3368     3371       +3     
+ Misses        374      369       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlfivefifty
Copy link
Copy Markdown
Member Author

@jishnub do you know why the downstream Aqua stale dependency test is failing?

@jishnub
Copy link
Copy Markdown
Member

jishnub commented Dec 17, 2025

I think it's because you've removed the test_args=["--downstream_integration_test"] from downstream.yml. This is needed since we explicitly dev BandedMatrices while testing against InfiniteArrays, but this package is only a weak dependency of InfiniteArrays. This means that there is now an entry in the Project.toml that isn't loaded, and the test_args flag skips this test in Aqua.

@dlfivefifty
Copy link
Copy Markdown
Member Author

OK. I removed it because it was breaking the ApproxFun.jl downstream test....

@jishnub
Copy link
Copy Markdown
Member

jishnub commented Dec 18, 2025

The ApproxFun failure should be fixed by JuliaApproximation/ApproxFun.jl#973

@dlfivefifty dlfivefifty merged commit 4c4a5ad into master Dec 18, 2025
18 checks passed
@dlfivefifty dlfivefifty deleted the Drop-old-version-checking branch December 18, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants